Open
Conversation
r4id4h
force-pushed
the
feat/redirect-after-login
branch
from
0890600 to
8348564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #74
This pull request includes changes to the login and callback behaviour. Before this a random number was persisted as state and checked on callback. As I understood during Authorization Code Flow the state should be used to transport all data you need. So with this change we save all additionalClientAuthParameters to the state. On callback success the redirectUriOverride parameter is checked and you get redirected if its set. For this to work state must be enabled and redirectUriOverride must be an allowed Parameter.