fix: stencil projects can build ionicons #1462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collections directory is used by consuming Stencil projects to append a project built with Stencil, to the build context of the current project using Stencil. It is weird, but means that for a project using Stencil (e.g.: Ionic Framework), to be able to build another project using Stencil (e.g.: Ionicons), it needs to be able to read in the generated collections metadata. I believe this mainly applies to the dist output target.
This was recently disabled/removed in the v8 work. This is the primary reason for the build error in: ionic-team/ionic-framework#30390.
There may be other ways to solve this problem. This is the primary way that I am aware resolves it.
Verification steps:
npm install
npm run build
dist/collection
npm pack
core/
directory of Ionic Frameworknpm install ./path-to-file
npm run build