Skip to content

fix: stencil projects can build ionicons #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jul 2, 2025

The collections directory is used by consuming Stencil projects to append a project built with Stencil, to the build context of the current project using Stencil. It is weird, but means that for a project using Stencil (e.g.: Ionic Framework), to be able to build another project using Stencil (e.g.: Ionicons), it needs to be able to read in the generated collections metadata. I believe this mainly applies to the dist output target.

This was recently disabled/removed in the v8 work. This is the primary reason for the build error in: ionic-team/ionic-framework#30390.

There may be other ways to solve this problem. This is the primary way that I am aware resolves it.

Verification steps:

  1. Clone the fork
  2. Install dependencies: npm install
  3. Build the project: npm run build
  4. Observe: collections are generated in dist/collection
  5. Pack the built output: npm pack
  6. Copy the .tgz into the core/ directory of Ionic Framework
  7. Install the .tgz: npm install ./path-to-file
  8. Build Ionic Framework: npm run build
  9. Observe: Ionic Framework builds successfully

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the build in Ionic, thank you! 🥂

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ❤

@christian-bromann christian-bromann merged commit 0e51cf1 into ionic-team:main Jul 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants