fix(input): prevent layout shift when hiding password toggle #30533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
requested changes
Jul 8, 2025
brandyscarney
approved these changes
Jul 9, 2025
brandyscarney
changed the title
|
Looks good! Thank you! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29562
What is the current behavior?
When an input with a password toggle is given
disabledorreadonly, hiding the password toggle causes a layout shift as it shrinks the height of the input component.What is the new behavior?
visibility: hiddeninstead of removing it from the DOM withdisplay: noneso it retains it's space but is still hidden and still removed from the accessibility tree.Does this introduce a breaking change?
Other information
This solution was suggested by @piotr-cz in the bug report.