Skip to content

fix(button): fix tokens on ionic theme #30440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 29, 2025

Issue number: internal


What is the new behavior?

  • Review button min-width and size of icons inside.
  • Fixed test for ionic theme, with the correct medium size.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Button Ionic theme

Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 4:04pm

@BenOsodrac BenOsodrac added the type: bug a confirmed bug report label May 29, 2025
@BenOsodrac BenOsodrac marked this pull request as ready for review May 29, 2025 13:22
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 29, 2025 13:22
@BenOsodrac BenOsodrac requested review from gnbm and brandyscarney and removed request for gnbm May 29, 2025 13:22
This reverts commit ed387c2, reversing
changes made to 09e9033.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants