feat(input): add styles for ionic theme for fill=solid - #30417
Merged
Conversation
- move input.outline.scss to input.ionic.scss; - add fill solid to states page;
- add tests for ionic solid input;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BenOsodrac
approved these changes
May 19, 2025
brandyscarney
requested changes
May 21, 2025
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good just a few requested changes on where styles are applied!
- specify attributes by classes type;
brandyscarney
approved these changes
May 22, 2025
…for border-radius;
ShaneK
approved these changes
May 23, 2025
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
This generally looks good to me! Great work 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
Does this introduce a breaking change?
Other information