Skip to content

chore(playwright): add click method to promise assertion lint checks #29740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2024
Merged

chore(playwright): add click method to promise assertion lint checks #29740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e29903
chore(playwright): add click method to promise assertion lint checks
sean-perkins Jul 30, 2024
a9806c5
test(accordion): resolve lint errors
sean-perkins Jul 30, 2024
015b02f
test(modal): resolve lint errors
sean-perkins Jul 30, 2024
19794e4
test(select): resolve lint errors
sean-perkins Jul 30, 2024
1002f0a
test(animation-builder): resolve lint errors
sean-perkins Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/custom-rules/await-playwright-promise-assertion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,5 @@ const ASYNC_PLAYWRIGHT_ASSERTS = [
'toHaveTitle',
'toHaveURL',
'toBeOK',
'click'
];
4 changes: 2 additions & 2 deletions core/src/components/accordion/test/disabled/accordion.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => {

await expect(accordion).toHaveClass(/accordion-collapsed/);

accordion.click();
await accordion.click();
await page.waitForChanges();

await expect(accordion).toHaveClass(/accordion-collapsed/);
Expand All @@ -71,7 +71,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => {

await expect(accordion).toHaveClass(/accordion-collapsed/);

accordion.click();
await accordion.click();
await page.waitForChanges();

await expect(accordion).toHaveClass(/accordion-collapsed/);
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/accordion/test/readonly/accordion.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => {

await expect(accordion).toHaveClass(/accordion-collapsed/);

accordion.click();
await accordion.click();
await page.waitForChanges();

await expect(accordion).toHaveClass(/accordion-collapsed/);
Expand All @@ -71,7 +71,7 @@ configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => {

await expect(accordion).toHaveClass(/accordion-collapsed/);

accordion.click();
await accordion.click();
await page.waitForChanges();

await expect(accordion).toHaveClass(/accordion-collapsed/);
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/modal/test/sheet/modal.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
const backdrop = page.locator('ion-modal ion-backdrop');

await handle.click();
backdrop.click();
await backdrop.click();

await ionBreakpointDidChange.next();

Expand Down
2 changes: 2 additions & 0 deletions core/src/components/select/test/basic/select.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,11 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
* is already visible. We manually click() the element instead
* to avoid flaky tests.
*/
/* eslint-disable custom-rules/await-playwright-promise-assertion */
el.click();
el.click();
el.click();
/* eslint-enable custom-rules/await-playwright-promise-assertion */
});

const alerts = await page.$$('ion-alert');
Expand Down
10 changes: 5 additions & 5 deletions core/src/utils/animation/test/animationbuilder/animation.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ const testNavigation = async (page: E2EPage) => {

await page.click('page-root ion-button.next');
await ionRouteDidChange.next();
page.click('page-one ion-button.next');
await page.click('page-one ion-button.next');
await ionRouteDidChange.next();
page.click('page-two ion-button.next');
await page.click('page-two ion-button.next');
await ionRouteDidChange.next();
page.click('page-three ion-back-button');
await page.click('page-three ion-back-button');
await ionRouteDidChange.next();
page.click('page-two ion-back-button');
await page.click('page-two ion-back-button');
await ionRouteDidChange.next();
page.click('page-one ion-back-button');
await page.click('page-one ion-back-button');
await ionRouteDidChange.next();
};
Loading