feat(item): add styles for disabled state in ionic theme #29583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
BenOsodrac
approved these changes
Jun 4, 2024
github-actions
bot
removed
package: angular
BenOsodrac
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Do we plan to add e2e tests for this component later? We could probably just add the ionic theme here: https://github.com/ionic-team/ionic-framework/blob/next/core/src/components/item/test/disabled/item.e2e.ts
There was a problem hiding this comment.
@rugoncalves Ideally, IMO we should have them separated. But for the sake of speed, I agree with @brandyscarney about adding it to that file.
There was a problem hiding this comment.
Thank you @brandyscarney for the help on this. @gnbm automated screenshot tests are running on the ionic theme for the disabled state.
Co-authored-by: Brandy Carney <[email protected]>
brandyscarney
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
ion-itemfor the Ionic themeDoes this introduce a breaking change?