Proper error handling/return code. #666
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Stripe sends an event to the webhook that this Stripe Payments Firebase extension creates (e.g. "https://us-central1-abcdefg.cloudfunctions.net/ext-firestore-stripe-payments-handleWebhookEvents"), and if an error happens, then the code returns to Stripe a success http status code (200). This is problematic because Stripe thinks that the webhook succeeded.
When the webhook fails with an example error message "An error occurred with our connection to Stripe" (like in my case), then I would rather Stripe know that it failed with the 500 internal server error status code so that it can properly do a retry process, rather than swallow it and forget about it. Without this PR code change, I would have to not use the extension, and write my own event handlers so that I can properly handle errors on the Stripe side of things.
The logic should ideally be:
This addresses that.