Skip to content

refactor: break up code into sensible modules #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: next
Choose a base branch
from
Draft

refactor: break up code into sensible modules #658

wants to merge 20 commits into from

Conversation

cabljac
Copy link
Collaborator

@cabljac cabljac commented Apr 9, 2025

This PR is refactoring and moving code about to make it more maintainable, readable, and testable.

@cabljac cabljac requested a review from Copilot April 9, 2025 15:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • firestore-stripe-invoices/functions/package.json: Language not supported
  • firestore-stripe-payments/functions/package.json: Language not supported
Comments suppressed due to low confidence (1)

firestore-stripe-payments/functions/src/controllers/checkout.ts:259

  • [nitpick] The error message for unsupported client types contains an extra space before 'mobile'. Consider revising it to: "Only 'web' or 'mobile' is supported!" for clarity.
throw new Error(`Client ${client} is not supported. Only 'web' or ' mobile' is supported!`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant