fix(deps): Update for ES Module compatibility #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "type": "module" and .js extensions to imports. This aligns the library with requirements for ECMAScript Modules, which are now widely adopted.
|
|
|
Resolves #440. Without these changes, the dependency is unusable in newer versions of Vite. Therefor it prohibits use in Vue, Nuxt 3, SvelteKit, Remix, Analog, Angular, Astro, SolidJS, Qwik City, RedwoodJS. |
No need to be so authoritative. Contributors are welcome to participate in a way that suites their workflow.
Adding this field required updating the Stripe SDK. It was quite out of date.
|
This fix has been published as See my fork, which additionally updates the package to the latest Stripe API (+ 2 years), uses modular Firebase package ( |
|
This really helped me! Thanks a lot @trentrand |
This was referenced Jan 16, 2025
* feat: bump to Node.js 20 runtimes * chore: run npm audit fix * chore: rename sensitive example file * chore: add secret file to gitignore * chore(CI): bump node in CI * chore(CI): bump deps in web sdk to fix CI Co-authored-by: Trent Rand <[email protected]>
Sometimes the consumer application would use a different instance of Firebase, and so calls like `parent instanceOf Payment` would fail because the two instances were technically from different modules. The package should now share the consumers instance of Firebase.
You can call `createCheckoutSession` and `createPortalLink` with the metadata parameter, and these will be saved as metadata fields for the created Stripe user.
This reverts commit 25300aa. The previous commit changed import statements for firebase-admin and firebase-functions to default imports, which caused the extension deployment to fail with runtime errors (Cannot read properties of undefined (reading 'auth')). The correct usage is to use namespace imports (import * as admin from 'firebase-admin'). This revert restores the working import style and fixes the deployment issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "type": "module" and .js extensions to imports. This aligns the library with requirements for ECMAScript Modules, which are now widely adopted.