Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test/verifycalls, e.g. in the scopes integration test, we callscope-test verify -only, so whenzpm verify -onlyis called, we end up nesting.^||%UnitTest.Manager.LastResultto track test runs. This iskilled at the start of the running of tests, which causes problems with nesting: the parent's results are killed by the child^||%UnitTest.Manager.AllResultsCountthat collates individual instantiations.ScopesandFileCopy.^||%UnitTest.Manager.LastResulthas been completely removed since IPM will no longer use it, so any custom code built on top of this will breakFAILED Test.PM.Integration.ProcessPythonWheel:TestWheelAndReqsPresentOnline: AssertEquals - reqVer== "1.6.4" was '1.6.2'.Testing
Ran
zpm verify -onlyand the tests pass. Also made sure if there is a failing test, theverifyphase will correctly fail. For nested tests, made sure that if the nested test fails, it will be properly reported in the summary at the end.Checklist
mainbranch rebased or merged.zpm test -only) and integration tests (zpm verify -only) pass.