feat: Add Book Talks carousel to the homepage with new data fetching … #11624
Conversation
for more information, see https://pre-commit.ci
mekarpeles
left a comment
mekarpeles
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Since these images are more horizontal (wide) than vertical (tall), we likely want to show fewer (e.g. just 3).
We also will want to show the title and the date (as otherwise it's unclear what the video is).
Furthermore, we'll want to move the css out of inline styles and into the correct files in `static/css
…, and interstitial video support.
for more information, see https://pre-commit.ci
Screen.Recording.mov |
github-actions
bot
added
the
Needs: Response
|
This is getting there! Nice work. It may be a little work, but rather than an external link, what we may want to do is have the watch button open up the archive.org item like we do for the preview as an iframe. This would allow patrons to stay on Open Library. We could also switch the URL slightly to go to /embed instead of /details e.g. instead of https://archive.org/details/history-disrupted we'd go to https://archive.org/embed/history-disrupted |
…ing the server-side redirect and video-related interstitial content.
for more information, see https://pre-commit.ci
Screen.Recording.mov |
|
Archive.org's embed shows a thumbnail with a play button first, then after clicking it loads and shows the actual player with another play button. Added an autoplay=1 parameter to the embed URL to make it start automatically when the modal opens. |
|
Nice work! I'll put this on testing. |
2 participants
Closes #11617
Feature Requested
Add new "Book Talks" carousel to homepage using archive.org API.
Screenshot
Changes