Fix #11572: Fix Solr updater cache clearing performance bug #11595
+16
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11572
The Solr updater has been experiencing reliability issues in recent weeks:
Root Cause
A cache clearing bug introduced in June 2021 (commit c24b3e7) was clearing the data provider cache after every 100-key batch instead of after each iteration. This caused:
Solution
Moved
data_provider.clear_cache()from inside the batch loop to after each iteration in the main event loop: