WEBDEV-8007 Add demo custom event usage to component and tests #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 29 41 +12
Branches 0 1 +1
=========================================
+ Hits 29 41 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbuckner
reviewed
Jan 2, 2026
| /** | ||
| * Custom events fired by the component | ||
| */ | ||
| enum Events { |
Contributor
There was a problem hiding this comment.
Something that jumped out at me... looking at most of the examples on the TS docs, I think enums are typically singular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample custom event dispatch, enum and test structure to help standardize the approach.