[SYCL free func] Refactor DepthwiseConv3dKernels by free function - #5098
Draft
minmingzhu wants to merge 1 commit into
Draft
[SYCL free func] Refactor DepthwiseConv3dKernels by free function#5098minmingzhu wants to merge 1 commit into
minmingzhu wants to merge 1 commit into
Conversation
github-actions
Bot
added
disable_e2e
minmingzhu
marked this pull request as draft
August 25, 2026 08:20
minmingzhu
marked this pull request as ready for review
August 26, 2026 02:48
minmingzhu
marked this pull request as draft
August 26, 2026 03:02
Convert 3 kernel functors to free functions: - ConvDepthwise3dXpuFunctor -> conv_depthwise3d_xpu_fn - ConvDepthwise3dXpuBackwardInputFunctor -> conv_depthwise3d_xpu_backward_input_fn - ConvDepthwise3dXpuBackwardWeightFunctor -> conv_depthwise3d_xpu_backward_weight_fn Test Plan: Build and UT to be run after all PRs are ported. Co-authored-by: Carson Wang <carson.wang@intel.com> Co-authored-by: Copilot <copilot@github.com>
minmingzhu
force-pushed
the
minmingz/depthwise-conv3d-free-func
branch
from
August 26, 2026 03:26
9767301 to
8d45218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DepthwiseConv3dKernels.cpp — Kernel UT Report
SYCL kernel conversion check: In
src/ATen/native/xpu/sycl/DepthwiseConv3dKernels.cpp, the following kernels are implemented/launched as free functions viaSYCL_EXT_ONEAPI_FUNCTION_PROPERTY((...))andsycl_kernel_submit<...>(...)function pointer:conv_depthwise3d_xpu_fn(line ~45)conv_depthwise3d_xpu_backward_input_fn(line ~135)conv_depthwise3d_xpu_backward_weight_fn(line ~232)No remaining Functor structs in this file — all SYCL kernel launch functors have been converted to free functions.
Changed-kernel related UTs:
test/xpu/test_nn_xpu.pypytest test/xpu/test_nn_xpu.py -v -k "(conv3d or Conv3d) and xpu"Co-authored-by: Copilot copilot@github.com