[SYCL] Extend range rounding tests to queue shortcut #20772
+334
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Introduce a kernel submission wrapper utility to E2E tests, and use it in the range rounding tests to increase the test coverage to the queue kernel submission shortcut function. The main motivation is to test the handler-less kernel submission path, once it is introduced (for range based submissions).
vinser52
reviewed
Nov 27, 2025
Comment on lines
+55
to
+56
| try_rounding_off(x, true); | ||
| try_rounding_off(x, false); |
Contributor
There was a problem hiding this comment.
nit: I would make the try_rounding_off and command_submit_wrappers::parallel_for_wrapper template functions that accept the bool useShortcutFunction as a template argument.
Contributor
Author
There was a problem hiding this comment.
This might be a bit tricky, as the kernel lambda is defined as a local variable in try_rounding_off. With a templated version of that function, we get two different lambda types, but submitted with the same kernel name.
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a kernel submission wrapper utility to E2E tests, and use it in the range rounding tests to increase the test coverage to the queue kernel submission shortcut function.
The main motivation is to test the handler-less kernel submission path, once it is introduced (for range based submissions).