Skip to content

Conversation

@lukaszstolarczuk
Copy link
Contributor

No description provided.

export SAVE_SUFFIX=$SAVE_SUFFIX
echo "SAVE_SUFFIX=$SAVE_SUFFIX" >> $GITHUB_ENV
export MACHINE_TYPE=$MACHINE_TYPE
echo "MACHINE_TYPE=$MACHINE_TYPE" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we could move all of this environment setup into the file called by this workflow that runs the benchmark?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm TBH I'm not sure if setting up env vars via script file would work in GHA in subsequent steps...?

Also, this script would be used only in this action, not sure if this would give any benefit...? For me it's good enough it's all now in one step, rather then scattered over a few steps.

@lukaszstolarczuk
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants