-
Notifications
You must be signed in to change notification settings - Fork 798
[CI][Bench] Refactor bench workflow #20742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
777ea28 to
144bedd
Compare
144bedd to
107e1b3
Compare
582bf20 to
2d0ae0b
Compare
3c623ab to
e43b8c7
Compare
e43b8c7 to
82b2f04
Compare
8eb3fe7 to
02b8752
Compare
02b8752 to
50b91ca
Compare
50b91ca to
0e87fcc
Compare
| export SAVE_SUFFIX=$SAVE_SUFFIX | ||
| echo "SAVE_SUFFIX=$SAVE_SUFFIX" >> $GITHUB_ENV | ||
| export MACHINE_TYPE=$MACHINE_TYPE | ||
| echo "MACHINE_TYPE=$MACHINE_TYPE" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we could move all of this environment setup into the file called by this workflow that runs the benchmark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm TBH I'm not sure if setting up env vars via script file would work in GHA in subsequent steps...?
Also, this script would be used only in this action, not sure if this would give any benefit...? For me it's good enough it's all now in one step, rather then scattered over a few steps.
0e87fcc to
8f57263
Compare
|
dispatch run: https://github.com/intel/llvm/actions/runs/19759131571/job/56617416122#step:19:1007 |
No description provided.