[SYCL][NFC] Pass adapter by reference in backend[_impl] #19187
+60
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
force-pushed
the
private/udit/adapter_refac2
branch
from
4c31021 to
0ee6f51
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
force-pushed
the
private/udit/adapter_refac2
branch
from
0ee6f51 to
0ed0037
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Jun 30, 2025
| switch (Backend) { | ||
| case backend::opencl: | ||
| return ur::getAdapter<backend::opencl>(); | ||
| return *ur::getAdapter<backend::opencl>(); |
There was a problem hiding this comment.
Should we add asserts to check that the ptr is not null?
There was a problem hiding this comment.
In a subsequent PR, I'll change ur::getAdapter to return adapter reference as well, so there won't be any potential null ptr deference.
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a part of larger refactoring effort to pass adapter via reference instead of pointer everywhere in the codebase.
Follow-up of:
#19186
#19184