[SYCL][UR][L0 v2] Fix uninitialized variable use #19032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isInOrder is initialized after eventPool
EwanC
reviewed
Jun 18, 2025
| @@ -67,8 +67,9 @@ ur_exp_command_buffer_handle_t_::ur_exp_command_buffer_handle_t_( | |||
| v2::raii::command_list_unique_handle &&commandList, | |||
| const ur_exp_command_buffer_desc_t *desc) | |||
| : eventPool(context->getEventPoolCache(PoolCacheType::Regular) | |||
| .borrow(device->Id.value(), | |||
| isInOrder ? v2::EVENT_FLAGS_COUNTER : 0)), | |||
| .borrow(device->Id.value(), (desc && desc->isInOrder) | |||
There was a problem hiding this comment.
Shouldn't need desc &&. Desc shouldn't be a nullptr according to https://oneapi-src.github.io/unified-runtime/core/api.html#urcommandbuffercreateexp which we rely on the validation layer to catch. If you look on line 247 you can see an example of dereferencing it without the nullptr check.
Also for lines 74 & 75
EwanC
approved these changes
Jun 18, 2025
|
This was based on changes reverted in #18962 I will create a new patch with all the fixes included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isInOrder is initialized after eventPool