-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Driver] Update -fsycl-dump-device-code option name. #18908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small items. Should we add this option to the UsersManual.md file as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for driver - just a comment on the doc update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. However, I do feel that the option can just be renamed as '-dump-device-code'. I do not have a strong objection. But, I am curious why '-save-offload-code' was preferred here.
Ping @intel/dpcpp-doc-reviewers |
This PR deprecates the usage of
-fsycl-dump-device-code
option, making this option backend-agnostic, extending its functionality beyond just SYCL to include OpenMP and other offloading models in the future, with the new option name:-save-offload-code=/path/to/offload/code/
(Linux) and-(or)/Qsave-offload-code=/path/to/offload/code/
(Windows)A diagnostic warning is emitted when
-fsycl-dump-device-code
option is passed to the Clang driver.Example: