Skip to content

[SYCL][Driver] Update -fsycl-dump-device-code option name. #18908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from

Conversation

srividya-sundaram
Copy link
Contributor

@srividya-sundaram srividya-sundaram commented Jun 10, 2025

This PR deprecates the usage of -fsycl-dump-device-code option, making this option backend-agnostic, extending its functionality beyond just SYCL to include OpenMP and other offloading models in the future, with the new option name: -save-offload-code=/path/to/offload/code/(Linux) and -(or)/Qsave-offload-code=/path/to/offload/code/ (Windows)

A diagnostic warning is emitted when -fsycl-dump-device-code option is passed to the Clang driver.
Example:

clang++ -fsycl -fsycl-dump-device-code= syclfile.cpp
clang++: warning: option '-fsycl-dump-device-code=' is deprecated and will be removed in a future release, use '-save-offload-code=' instead [-Wdeprecated]

@srividya-sundaram srividya-sundaram marked this pull request as ready for review June 10, 2025 21:47
@srividya-sundaram srividya-sundaram requested a review from a team as a code owner June 10, 2025 21:47
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small items. Should we add this option to the UsersManual.md file as well?

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for driver - just a comment on the doc update.

Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. However, I do feel that the option can just be renamed as '-dump-device-code'. I do not have a strong objection. But, I am curious why '-save-offload-code' was preferred here.

@srividya-sundaram
Copy link
Contributor Author

Ping @intel/dpcpp-doc-reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants