[UR][CTS] Update USM tests to prevent crashes in offload adapter #18891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CTS tests for USM uses `EXPECT_SUCCESS` when it should really be `ASSERT_SUCCESS` (the latter returns, which looks to have been the intended behaviour). In addition, some tests have been marked with a new `uur::Offload` known failure, as they cause liboffload to hit an abort.
kbenzie
approved these changes
Jun 10, 2025
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTS tests for USM uses
EXPECT_SUCCESSwhen it should really beASSERT_SUCCESS(the latter returns, which looks to have been theintended behaviour).
In addition, some tests have been marked with a new
uur::Offloadknown failure, as they cause liboffload to hit an abort.