-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL] Always store last event (for ioq) if scheduler was not bypassed #18867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
uditagarwal97
merged 4 commits into
intel:sycl
from
igchor:store_last_event_if_no_scheduler_bypass
Jun 18, 2025
Merged
[SYCL] Always store last event (for ioq) if scheduler was not bypassed #18867
uditagarwal97
merged 4 commits into
intel:sycl
from
igchor:store_last_event_if_no_scheduler_bypass
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baf4b56
to
28c0a70
Compare
slawekptak
reviewed
Jun 10, 2025
slawekptak
reviewed
Jun 10, 2025
12b4f2c
to
aa174ab
Compare
slawekptak
approved these changes
Jun 13, 2025
aa174ab
to
59291ad
Compare
59291ad
to
64a2c2c
Compare
7fabad1
to
221036e
Compare
221036e
to
31fa791
Compare
This looks like it has unintended changes to image.cpp in UR? |
JackAKirk
reviewed
Jun 17, 2025
31fa791
to
e0176c7
Compare
e0176c7
to
995923f
Compare
pbalcer
approved these changes
Jun 18, 2025
JackAKirk
approved these changes
Jun 18, 2025
995923f
to
1d9a9e2
Compare
on host-task. This covers case not properly handled by in-order no event mode optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue for cases where the kernel depends on events coming from the scheduler (host task events or unenqueued commands). The logic in
submit_impl
for calculatingnoLastEventPath
did not take into account all dependencies which could result in skipping storing last even ifhandler.finalize()
ended up submitting work to the scheduler.I also restored the lock on the submit path. It is needed to store the last event in case
handler.finalize()
returns an event coming from the scheduler.