Skip to content

[SYCL] Always store last event (for ioq) if scheduler was not bypassed #18867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

igchor
Copy link
Member

@igchor igchor commented Jun 9, 2025

This fixes an issue for cases where the kernel depends on events coming from the scheduler (host task events or unenqueued commands). The logic in submit_impl for calculating noLastEventPath did not take into account all dependencies which could result in skipping storing last even if handler.finalize() ended up submitting work to the scheduler.

I also restored the lock on the submit path. It is needed to store the last event in case handler.finalize() returns an event coming from the scheduler.

@igchor igchor requested a review from a team as a code owner June 9, 2025 18:43
@igchor igchor requested a review from slawekptak June 9, 2025 18:43
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 18:43 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 19:05 — with GitHub Actions Inactive
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from baf4b56 to 28c0a70 Compare June 9, 2025 21:13
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:13 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:35 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:35 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 13, 2025 21:11 — with GitHub Actions Inactive
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from aa174ab to 59291ad Compare June 16, 2025 14:45
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from 59291ad to 64a2c2c Compare June 16, 2025 15:24
@igchor igchor temporarily deployed to WindowsCILock June 16, 2025 15:25 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 16, 2025 16:04 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 16, 2025 16:04 — with GitHub Actions Inactive
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from 7fabad1 to 221036e Compare June 16, 2025 20:59
@igchor igchor temporarily deployed to WindowsCILock June 16, 2025 21:21 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 16, 2025 21:21 — with GitHub Actions Inactive
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from 221036e to 31fa791 Compare June 17, 2025 14:40
@igchor igchor requested review from a team as code owners June 17, 2025 14:40
@JackAKirk
Copy link
Contributor

This looks like it has unintended changes to image.cpp in UR?

@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from 31fa791 to e0176c7 Compare June 17, 2025 14:46
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from e0176c7 to 995923f Compare June 17, 2025 14:51
@igchor igchor temporarily deployed to WindowsCILock June 17, 2025 14:51 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 17, 2025 16:59 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 17, 2025 16:59 — with GitHub Actions Inactive
@igchor igchor force-pushed the store_last_event_if_no_scheduler_bypass branch from 995923f to 1d9a9e2 Compare June 18, 2025 15:28
@igchor igchor temporarily deployed to WindowsCILock June 18, 2025 15:28 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 18, 2025 16:16 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 18, 2025 16:16 — with GitHub Actions Inactive
@igchor
Copy link
Member Author

igchor commented Jun 18, 2025

@intel/llvm-gatekeepers this is ready to be merge. The failure is related to #18932 and wrong exclusion check in lit.local.cfg - fix is here: #19061

@uditagarwal97 uditagarwal97 merged commit 2799ba3 into intel:sycl Jun 18, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants