[SYCL] Allow __glibcxx_assert_fail in SemaSYCL #18856
Conversation
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
| if (IsAllowed) | ||
| return true; | ||
|
|
||
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | ||
| // extensively used in STL to do runtime check in debug mode. The behavior | ||
| // is similar to "assert", we have supported it in libdevice in the same way | ||
| // as "assert". However, Sema check will report "undefined function without | ||
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | ||
| // what we did to "__failed_assertion". The prototype is following: | ||
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | ||
| IsAllowed = (Callee->getName() == GlibcxxAssertFail) && | ||
| Callee->getNumParams() == 4 && |
There was a problem hiding this comment.
| if (IsAllowed) | |
| return true; | |
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | |
| // extensively used in STL to do runtime check in debug mode. The behavior | |
| // is similar to "assert", we have supported it in libdevice in the same way | |
| // as "assert". However, Sema check will report "undefined function without | |
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | |
| // what we did to "__failed_assertion". The prototype is following: | |
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | |
| IsAllowed = (Callee->getName() == GlibcxxAssertFail) && | |
| Callee->getNumParams() == 4 && | |
| // GCC-15 introduced "std::__glibcxx_assert_fail" declared c++config.h and | |
| // extensively used in STL to do runtime check in debug mode. The behavior | |
| // is similar to "assert", we have supported it in libdevice in the same way | |
| // as "assert". However, Sema check will report "undefined function without | |
| // SYCL_EXTERNAL attribute" error in some cases. We have to allow it just as | |
| // what we did to "__failed_assertion". The prototype is following: | |
| // void __glibcxx_assert_fail(const char *, int, const char *, const char*); | |
| IsAllowed = IsAllowed || (Callee->getName() == GlibcxxAssertFail) && | |
| Callee->getNumParams() == 4 && |
|
Hi, @intel/dpcpp-cfe-reviewers |
|
Hi, @intel/dpcpp-cfe-reviewers |
|
Hi, @intel/llvm-gatekeepers |
|
Has the nit from @yingcong-wu been addressed? |
As in the comment, it is just a nit. I am fine with the current implementation as is. |
Ok, I've merged. In the future, please use "Approve" in these cases to make it easier for gatekeepers to assess the status of a PR. |
Will do, thank you. |
GCC-15 introduced __glibcxx_assert_fail function used in -O0 for many STL functions' runtime check. Its behavior is similar to normal 'assert', so we have supported it in libdevice in the same way as 'assert'. However, compfail will happen in some scenario reporting "undefined function without SYCL_EXTERNAL" error for "__glibcxx_assert_fail" declared in c++config.h, we have to allow this as exception in SemaSYCL.