[SYCL][NFCI] Drop __spirv_ops.hpp from core.hpp
#18839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our device compiler have been capable of automagically declaring necessary SPIR-V built-ins on the fly for a while now, meaning that we don't need them to be forward-declared in headers. This PR drops includes of `__spirv_ops.hpp` so that they don't appear anymore in `core.hpp` (and some other headers). The header is not removed entirely, however, because not every built-in is known to the compiler, i.e. some of them still have to be forward-declared in the header. Most likely there are other places which can be made free of uses of the header and the header itself can probably be cleaned up agressively, but I will leave it for separate future PRs.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
commented
Jun 6, 2025
| @@ -73,10 +73,10 @@ template <typename T, typename Properties> | |||
| void prefetch_impl(T *ptr, size_t bytes, Properties properties) { | |||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| auto *ptrGlobalAS = | |||
| reinterpret_cast<__attribute__((opencl_global)) const char *>( | |||
| reinterpret_cast<__attribute__((opencl_global)) const unsigned char *>( | |||
There was a problem hiding this comment.
Note for reviewers: compiler only declares signed and unsigned char overloads, hence the change.
We could probably tweak the compiler to have plain char overloads as well, but I'm not sure that it won't cause any unwanted side effects, so I went with this change for now.
unsigned char should be a safe choice when it comes to object representation
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Can you share more on how does that work? |
uditagarwal97
approved these changes
Jun 13, 2025
| // Atomic SPIR-V builtins | ||
| // TODO: drop these forward-declarations. | ||
| // As of right know, compiler does not forward-declare long long overloads for |
There was a problem hiding this comment.
Suggested change
| // As of right know, compiler does not forward-declare long long overloads for | |
| // As of now, compiler does not forward-declare long long overloads for |
@uditagarwal97, see patches from @Naghasan: #1345, #1374, #1384. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our device compiler have been capable of automagically declaring necessary SPIR-V built-ins on the fly for a while now, meaning that we don't need them to be forward-declared in headers.
This PR drops includes of
__spirv_ops.hppso that they don't appear anymore incore.hpp(and some other headers).The header is not removed entirely, however, because not every built-in is known to the compiler, i.e. some of them still have to be forward-declared in the header.
Most likely there are other places which can be made free of uses of the header and the header itself can probably be cleaned up agressively, but I will leave it for separate future PRs.