[SYCL] Add size to detail::string_view

[Alexandr-Konovalov]

This allows us to pass size of kernel name that is known in compile time, not compute the size in run time.

[frasercrmck]

FYI I see the same sort of Arc A-Series failures, tracked in #18668.

[jbrodman]

So the basic idea here is that we compute the string length once at the start then can reuse the length every time we create a new view of it?

[Alexandr-Konovalov]

So the basic idea here is that we compute the string length once at the start then can reuse the length every time we create a new view of it?

Actually, KernelNameStr is constexpr and I see no string length computation at run time.

[steffenlarsen]

Overall LGTM! One smallish suggestion.

[steffenlarsen]

Do the str argument constness need to differ between the definitions? I would prefer we keep them the same, even if it means removing const in the variant below. If it gets removed with breaking changes, I would argue it's better to have it the same and avoid the potential hidden faulty const use-cases we could have.

[Alexandr-Konovalov]

Sorry, probably I do not understand. Are you for passing detail::string_view by const reference, like this?

inline KernelNameStrT toKernelNameStrT(const ABINeutralKernelNameStrT &str) {
#ifdef __INTEL_PREVIEW_BREAKING_CHANGES
  return std::string_view(str);
#else
  return str.data();
#endif
}

[steffenlarsen]

If that is an option, that would be good! My point is just to avoid differing constness of the reference argument in the function.

[Alexandr-Konovalov]

Sure, let's unify.

[hvdijk]

As in #18565, this PR shows sycl/test/native_cpu/multiple_definitions.cpp being added but that doesn't belong in this PR, that came from #18726 and something went wrong in updating this PR.

[Alexandr-Konovalov]

As in #18565, this PR shows sycl/test/native_cpu/multiple_definitions.cpp being added but that doesn't belong in this PR, that came from #18726 and something went wrong in updating this PR.

Thank you, removed form this PR as well.

[Alexandr-Konovalov]

Colleagues @steffenlarsen , @Bensuo , could it be merged or not yet?

[steffenlarsen]

Definitely!