Skip to content

[SYCL][libdevice] Remove invalid noreturn warning for glibcxx_assert #18657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented May 26, 2025

No description provided.

@jinge90 jinge90 requested a review from a team as a code owner May 26, 2025 03:00
@jinge90 jinge90 requested a review from steffenlarsen May 26, 2025 03:00
@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 03:00 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 03:23 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 03:23 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from steffenlarsen May 26, 2025 05:39
@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 09:50 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 10:15 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 26, 2025 10:15 — with GitHub Actions Inactive
Signed-off-by: jinge90 <[email protected]>
@jinge90 jinge90 temporarily deployed to WindowsCILock May 27, 2025 02:44 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 27, 2025 03:07 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 27, 2025 03:07 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock May 28, 2025 02:01 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from a team May 28, 2025 02:50
@jinge90
Copy link
Contributor Author

jinge90 commented May 28, 2025

Hi, @intel/llvm-gatekeepers
Could you merge this PR?
Thanks very much.

@uditagarwal97 uditagarwal97 merged commit 5778810 into intel:sycl May 28, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants