Skip to content

[SYCL] Enable UR validation layer on SYCL RT e2e precommit jobs #18651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

martygrant
Copy link
Contributor

@martygrant martygrant commented May 23, 2025

We would like to enable the validation layer in UR for the precommit e2e testing jobs. This layer is disabled currently to bypass the overhead of extra checks, but the same checks have propagated through to the UR adapters where they are not required. If the checks are removed from the adapters then some e2e tests will fail as some incorrect usage is not being caught by the validation layer.

Docs on UR layers: https://oneapi-src.github.io/unified-runtime/core/INTRO.html#layers

Closes #18257

@martygrant martygrant requested a review from a team as a code owner May 23, 2025 14:20
@martygrant martygrant changed the title Enable UR validation layer on SYCL RT e2e precommit jobs [SYCL] Enable UR validation layer on SYCL RT e2e precommit jobs May 23, 2025
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to have a performance impact on test runtime? If so do we have an idea of how much? Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UR][CI] Add new job to build UR with validation layer enabled
2 participants