[SYCL] Simplify secondary queue usage #18642
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirement of SYCL submit functions taking a secondary queue does not mandate more than that the runtime must attempt to enqueue onto the secondary queue if the it fails to enqueue on the primary queue. Using this, the SYCL implementation can be simplified to simply retry the enqueue if the enqueue to the primary queue throws an exception. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
force-pushed
the
steffen/simplify_secondary_queue_usage
branch
from
936c1a4 to
8464d43
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
commented
Jun 2, 2025
| @@ -456,14 +456,12 @@ class __SYCL_EXPORT handler { | |||
| /// is null if no secondary queue is associated with the submission. | |||
| /// \param CallerNeedsEvent indicates if the event resulting from this handler | |||
| /// is needed by the caller. | |||
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | |||
There was a problem hiding this comment.
Note: This was redundant.
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following KhronosGroup/SYCL-Docs#811, the SYCL 2020 specification will not mandate the use nor exception checking of secondary queues. This allows us to relax the interfaces taking a secondary queue to fully ignore it. This commit drops the passing of the secondary queue throughout the pipeline.