Skip to content

[CI] Enable v2 adapter testing on BMG #18357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from

Conversation

igchor
Copy link
Member

@igchor igchor commented May 7, 2025

No description provided.

@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 20:23 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 21:01 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 7, 2025 21:01 — with GitHub Actions Inactive
@igchor igchor force-pushed the enable_testing_v2_on_pvc branch from 9f63093 to 6f011d1 Compare May 8, 2025 17:51
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 17:51 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 19:06 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock May 8, 2025 19:06 — with GitHub Actions Inactive
@aelovikov-intel aelovikov-intel changed the title [CI] enable v2 adapter testing on pvc [CI] Enable v2 adapter testing on pvc May 12, 2025
@igchor igchor force-pushed the enable_testing_v2_on_pvc branch from 6f011d1 to fc25582 Compare June 3, 2025 14:46
@igchor igchor temporarily deployed to WindowsCILock June 3, 2025 14:46 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 3, 2025 16:18 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 3, 2025 16:18 — with GitHub Actions Inactive
@igchor igchor force-pushed the enable_testing_v2_on_pvc branch from fc25582 to ec8a3f4 Compare June 9, 2025 21:16
@igchor igchor changed the title [CI] Enable v2 adapter testing on pvc [CI] Enable v2 adapter testing on PVC and BMG Jun 9, 2025
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:16 — with GitHub Actions Inactive
@igchor igchor marked this pull request as ready for review June 9, 2025 21:16
@igchor igchor requested review from a team as code owners June 9, 2025 21:16
@igchor igchor requested a review from againull June 9, 2025 21:16
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:57 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock June 9, 2025 21:57 — with GitHub Actions Inactive
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarnex , @uditagarwal97 , do we have enough runners capacity in CI for that?

@uditagarwal97
Copy link
Contributor

@sarnex , @uditagarwal97 , do we have enough runners capacity in CI for that?

Here's the time taken by E2E jobs before and after this PR:
PVC: 6m 24s --> 14m 31s (https://github.com/intel/llvm/actions/runs/15544819604/job/43765014831?pr=18357)
BMG: 4m 26s --> 7m 14s

Overhead on PVC seems significant to me. IIRC, we also had one PVC runner also used for build. @sarnex have you seen PVC being a bottleneck recently? I think we should be good with BMG, although we have only one Linux BMG runner, I haven't experienced BMG being a bottleneck recently.

@sarnex
Copy link
Contributor

sarnex commented Jun 9, 2025

PVC GPU hasn't been a blocker recently, but I agree the more than doubling of the job time is worrying.

@aelovikov-intel
Copy link
Contributor

PVC GPU hasn't been a blocker recently, but I agree the more than doubling of the job time is worrying.

That seems to be due to the timeout, so not representative. That said, timeout in itself is a problem.

@sarnex
Copy link
Contributor

sarnex commented Jun 9, 2025

Ah sorry, it would be nice to see some results we think are representative of normal runs.

@igchor
Copy link
Member Author

igchor commented Jun 10, 2025

Yes, I'm investigating the timeouts right now - it seems to be related to copy offload (so likely a driver issue). For now, perhaps we can enable the testing just for BMG?

@aelovikov-intel
Copy link
Contributor

For now, perhaps we can enable the testing just for BMG?

👍

@igchor igchor changed the title [CI] Enable v2 adapter testing on PVC and BMG [CI] Enable v2 adapter testing on BMG Jun 10, 2025
@igchor igchor temporarily deployed to WindowsCILock June 10, 2025 15:07 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants