[SYCL][UR][CMake] Stop creating debug library builds on Windows during release builds#18200
Closed
steffenlarsen wants to merge 47 commits intointel:syclfrom
Closed
[SYCL][UR][CMake] Stop creating debug library builds on Windows during release builds#18200steffenlarsen wants to merge 47 commits intointel:syclfrom
steffenlarsen wants to merge 47 commits intointel:syclfrom
Conversation
added 3 commits
April 11, 2025 06:13
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
added 2 commits
April 27, 2025 21:56
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
added 3 commits
April 28, 2025 01:38
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
kbenzie
approved these changes
May 22, 2025
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
added 3 commits
May 22, 2025 06:53
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
added 6 commits
May 22, 2025 08:16
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
added 5 commits
May 28, 2025 11:51
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
commented
Jun 5, 2025
| set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS OFF) | ||
|
|
||
| set(CMAKE_MSVC_RUNTIME_LIBRARY_BAK "${CMAKE_MSVC_RUNTIME_LIBRARY}") | ||
| # UMF has not yet been able to build as static |
Contributor
Author
There was a problem hiding this comment.
@kbenzie - Do you know if this is still a problem? I was able to build in static configuration locally without any issues.
Contributor
There was a problem hiding this comment.
I think that's a question for a UMF maintainer @bratpiorka
Contributor
There was a problem hiding this comment.
I'm not sure what is behind this comment, but since everything is working now, that's great
| if (SYCL_ENABLE_XPTI_TRACING) | ||
| target_link_libraries(${LIB_NAME} PRIVATE ${CMAKE_DL_LIBS}) | ||
| target_link_libraries(${LIB_TARGET_NAME} PRIVATE ${CMAKE_DL_LIBS}) | ||
| endif() |
Contributor
There was a problem hiding this comment.
l201. should it be LIB_TARGET_NAME too?
Contributor
Author
There was a problem hiding this comment.
Yes! Good catch.
| # Version-agnostic name of the import library, has effect on Windows only. | ||
| set(IMPLIB_NAME "sycl") | ||
| set(IMPLIB_PREVIEW_NAME "${IMPLIB_NAME}-preview") | ||
| if (CMAKE_BUILD_TYPE STREQUAL Debug OR CMAKE_MSVC_RUNTIME_LIBRARY STREQUAL MultiThreadedDebugDLL) |
Contributor
There was a problem hiding this comment.
do we not have "if (WIN32)" or similar check here because we apply this setting in add_sycl_rt_library for windows only? can we just set IMPLIB_* vars at l348 and do changes in the win path together with other name related vars?
Contributor
Author
There was a problem hiding this comment.
do we not have "if (WIN32)" or similar check here because we apply this setting in add_sycl_rt_library for windows only?
Exactly!
can we just set IMPLIB_* vars at l348 and do changes in the win path together with other name related vars?
We could, e.g. by moving the first sets here to before the if (WIN32), but it does make the fact that this just appends a d to the names a little less obvious. If you think it is better I will happily do it though. 👍
added 4 commits
July 2, 2025 14:07
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Contributor
Author
|
Closing while this gets reassigned to someone who has time to maintain it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the SYCL library and its constituents build both a release build and a debug build (/MDd) on Windows, no matter what the build type is. This PR changes the build to only build in the mode specified by the CMAKE_BUILD_TYPE, meaning that packaging of release builds must build both explicitly and copy the files into the packages.
To allow parity with old builds, the
-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDebugDLLcan be used during configuration to use the debug UCRT in release mode, generating "d"-suffixed libraries. This can also be controlled in the configure.py script using the --use-debug-crt-dll option.Additionally, this PR adds a new test that checks that library files in build mode all have the required postfix ("d" or "d-preview") when they link with Windows debug URCT, and the release variant if not.