Skip to content

[UR][SYCL] Add urUSMContextMemcpyExp API to enable device global support. #17268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 5, 2025

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Mar 3, 2025

Also adds a path using the new api to avoid a workaround introduced in #16565

@aarongreig aarongreig marked this pull request as ready for review March 7, 2025 12:27
@aarongreig aarongreig requested review from a team as code owners March 7, 2025 12:27
@aarongreig aarongreig requested a review from ldrumm March 7, 2025 12:27
Copy link
Contributor

@Seanst98 Seanst98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA changes LGTM

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR spec & test LGTM

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0 lgtm.

@aarongreig aarongreig requested review from a team as code owners April 11, 2025 11:06
@aarongreig
Copy link
Contributor Author

@intel/unified-runtime-reviewers-level-zero this needs a re-approval because the l0 review group was added since opening the PR

@aarongreig
Copy link
Contributor Author

@intel/llvm-reviewers-cuda looks like this needs a re-approval, the adapter changes were previously approved not sure why that review seems to have been discounted

Copy link
Contributor

@frasercrmck frasercrmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA LGTM

@aarongreig
Copy link
Contributor Author

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit f2fa176 into intel:sycl Jun 5, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.