🐛 Fix clang-tidy operation
#109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbeno
force-pushed
the
update-clang-tidy
branch
from
0222bad to
bf737db
Compare
elbeno
force-pushed
the
update-clang-tidy
branch
4 times, most recently
from
fead1de to
0253b7f
Compare
Problem: - The `AnalyzeTemporaryDtors` option was **removed** in clang-tidy-18, which means that clang-tidy was failing to parse the .clang-tidy file. - Incredibly, clang-tidy exits with **success** if it fails to parse the .clang-tidy file! Therefore all clang-tidy runs were passing without actually tidying anything. Solution: - Remove `AnalyzeTemporaryDtors` option from .clang-tidy
Problem: - Some checks are aliases for other checks. `clang-tidy` does not deduplicate such checks; it just runs the same check twice - Some things have changed since last updating `clang-tidy` checks. - The `clang-tidy` checks that are configured are not documented. Solution: - Remove alias checks. - Update a few other checks. - Add documentation for configured checks.
Problem: - `clang-tidy` exits with success if the `.clang-tidy` file is ill-formed. Solution: - Add a clang-tidy-canary target which tests if `clang-tidy` has any error output when run with `--verify-config`.
elbeno
force-pushed
the
update-clang-tidy
branch
from
0253b7f to
5afeef4
Compare
mjcaisse-intel
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AnalyzeTemporaryDtorsoption was removed in clang-tidy-18, which means that clang-tidy was failing to parse the .clang-tidy file.Note: