Bug fix: Replace WAWrapperLinear with FakeActQuantLinear instead of Linear - #2245
Open
xin3he wants to merge 8 commits into
Open
Bug fix: Replace WAWrapperLinear with FakeActQuantLinear instead of Linear#2245xin3he wants to merge 8 commits into
xin3he wants to merge 8 commits into
Conversation
…nd group sizes Signed-off-by: Xin He <xin3.he@intel.com>
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…f fake-quantized models Signed-off-by: Xin He <xin3.he@intel.com>
wenhuach21
reviewed
Aug 27, 2026
| # set model_type for ModelFreeCompressor. | ||
| model_type = detect_model_type(eval_folder) | ||
| # When fake+no-save, detect from the model object to avoid HF Hub access. | ||
| type_probe = model if (is_fake_format and not envs.AR_SAVE_FAKE_MODEL) else eval_folder |
Contributor
There was a problem hiding this comment.
It would be better to always use the online fake model for evaluation when combined with tuning.
Contributor
There was a problem hiding this comment.
is torch compile supported in get_act_quant_func?
wenhuach21
reviewed
Aug 27, 2026
| **kwargs, | ||
| ): | ||
| if not envs.AR_SAVE_FAKE_MODEL: | ||
| logger.warning( |
Contributor
Author
There was a problem hiding this comment.
The default behavior of other formats is saving model, so warning is better.
wenhuach21
approved these changes
Aug 27, 2026
wenhuach21
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the refinements. This really helps!
Signed-off-by: Xin He <xin3.he@intel.com>
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ation logic, and enhance state dict normalization Signed-off-by: Xin He <xin3.he@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous change breaks activation qdq hook #2123
Type of Change
Bug fix
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.