Skip to content

Bug fix: Replace WAWrapperLinear with FakeActQuantLinear instead of Linear - #2245

Open
xin3he wants to merge 8 commits into
mainfrom
xinhe/8-26b
Open

Bug fix: Replace WAWrapperLinear with FakeActQuantLinear instead of Linear#2245
xin3he wants to merge 8 commits into
mainfrom
xinhe/8-26b

Conversation

@xin3he

@xin3he xin3he commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Previous change breaks activation qdq hook #2123

Type of Change

Bug fix

Related Issues

Fixes or relates to #

Checklist Before Submitting

  • My code has been tested locally.
  • Documentation has been updated as needed.
  • New or updated tests are included where applicable.
  • The CUDA CI has passed. You can trigger it by commenting /azp run Unit-Test-CUDA-AutoRound.

…nd group sizes

Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

…f fake-quantized models

Signed-off-by: Xin He <xin3.he@intel.com>
Comment thread auto_round/eval/evaluation.py Outdated
# set model_type for ModelFreeCompressor.
model_type = detect_model_type(eval_folder)
# When fake+no-save, detect from the model object to avoid HF Hub access.
type_probe = model if (is_fake_format and not envs.AR_SAVE_FAKE_MODEL) else eval_folder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to always use the online fake model for evaluation when combined with tuning.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is torch compile supported in get_act_quant_func?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is.

**kwargs,
):
if not envs.AR_SAVE_FAKE_MODEL:
logger.warning(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

info

@xin3he xin3he Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default behavior of other formats is saving model, so warning is better.

@wenhuach21 wenhuach21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refinements. This really helps!

@xin3he
xin3he requested a review from wenhuach21 August 27, 2026 05:11
xin3he added 3 commits August 27, 2026 13:13
Signed-off-by: Xin He <xin3.he@intel.com>
Signed-off-by: Xin He <xin3.he@intel.com>
@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xin3he

xin3he commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@xin3he

xin3he commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AutoRoundBot

Copy link
Copy Markdown
Collaborator

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

…ation logic, and enhance state dict normalization

Signed-off-by: Xin He <xin3.he@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants