Added Change Disk Command #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @kurucu Thank you for this PR. Could you please explain the use case for this command? |
Author
|
Yep! I recently moved my server to cloud hosting and as such, moved files from local disk to s3. I did this migration manually to achieve that. I’m sure there’s many similar use cases. Moving from s3 to r2, different disk names etc. Hopefully this saves people time in the future. |
BorschCode
reviewed
Nov 21, 2025
| $bar = $this->output->createProgressBar(Media::count() + Account::count()); | ||
| $bar->start(); | ||
|
|
||
| Media::chunk(100, function (Collection $medias) use ($bar, $from, $to) { |
There was a problem hiding this comment.
100 is a magic number here. It should be provided as an argument in the command or named explicitly as a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a change disk command that:
Performed as a chunked transaction so that json updates can be conditional.
Included a simple test for the command.