Skip to content

View child fix for Angular 9 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeMellon wants to merge 3 commits into
base: master
Choose a base branch
from
Open

View child fix for Angular 9 #131

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3482df3
ViewChild fix for Angular 9.
JoeMellon Jun 9, 2020
08d675f
comment
JoeMellon Jun 10, 2020
f766845
Implement AfterViewInit interface to component
JoeMellon Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/components/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ import { MapMarkerDirective } from './map-marker';
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush
})
export class MapComponent implements OnChanges, OnInit, OnDestroy {
export class MapComponent implements OnChanges, OnInit, AfterViewInit, OnDestroy {

///
/// Field declarations
Expand All @@ -92,7 +92,7 @@ export class MapComponent implements OnChanges, OnInit, OnDestroy {
private _options: IMapOptions = {};
private _box: IBox = null;
private _mapPromise: Promise<void>;
@HostBinding('class.map-container') public _containerClass: boolean = true;
@HostBinding('class.map-container') public _containerClass = true;
@ViewChild('container') private _container: ElementRef;
@ContentChildren(MapMarkerDirective) private _markers: Array<MapMarkerDirective>;

Expand Down Expand Up @@ -276,11 +276,19 @@ export class MapComponent implements OnChanges, OnInit, OnDestroy {
* @memberof MapComponent
*/
public ngOnInit(): void {
this.InitMapInstance(this._container.nativeElement);
this.MapPromise.emit(this._mapService.MapPromise);
this.MapService.emit(this._mapService);
}

/**
* Called after Angular has fully initialized a component's view. Part of ng Component life cycle.
*
* @memberof MapComponent
*/
public ngAfterViewInit(): void {
this.InitMapInstance(this._container.nativeElement);
}

/**
* Called when changes to the databoud properties occur. Part of the ng Component life cycle.
*
Expand Down