- 
                Notifications
    
You must be signed in to change notification settings  - Fork 476
 
Fixes issue: InfluxDBResultMapper doesnt call POJO setter #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1) Calling field setters if available before falling back to setting fields directly.
| 
           @fmachado  | 
    
| 
           @sjoshid thanks for submitting this PR. 
 I don't remember when was the last time that I had to run that shell script as I'm using the checkstyle.xml for a while. But before getting into the formatting issues, could you please check why Travis build failed? https://travis-ci.org/github/influxdata/influxdb-java/builds/685113586  | 
    
1) Handling NPE
1) Fixing Checkstyle errors.
          Codecov Report
 @@             Coverage Diff              @@
##             master     #676      +/-   ##
============================================
- Coverage     88.18%   88.11%   -0.07%     
- Complexity      722      737      +15     
============================================
  Files            69       69              
  Lines          2513     2566      +53     
  Branches        268      285      +17     
============================================
+ Hits           2216     2261      +45     
- Misses          208      210       +2     
- Partials         89       95       +6     
 Continue to review full report at Codecov. 
  | 
    
| 
           @fmachado  | 
    
| 
           whats the status on this? this would be a super useful feature to have  | 
    
| 
           
 Codecov ReportAttention: Patch coverage is  
 
 ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@             Coverage Diff              @@
##             master     #676      +/-   ##
============================================
- Coverage     88.18%   88.11%   -0.07%     
- Complexity      722      737      +15     
============================================
  Files            69       69              
  Lines          2513     2566      +53     
  Branches        268      285      +17     
============================================
+ Hits           2216     2261      +45     
- Misses          208      210       +2     
- Partials         89       95       +6     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
Closes #670
Things included in this PR: