fixing _split_by_lang in rag_tokenizer.py #3209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHuSh
reviewed
Jan 12, 2026
| zh = _zh | ||
| if s >= len(a): | ||
| continue | ||
| txt_lang_pairs.append((a[s:e], zh)) |
There was a problem hiding this comment.
Appreciations!
I can't see any side effects If e exceeds the length of a.
a[s:min(e, len(a))] equals to a[s:e].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Guarding the final slice in _split_by_lang ensures we never run past the end of the segment when e can temporarily exceed len(a) (e.g., when the last run updates e = s + 1). The change now clamps the upper bound with min(e, len(a)), so we always append a valid substring and avoid the occasional “list index out of range” crash the tokenizer was seeing.
Type of change