-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
feat: add factory enum #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add factory enum #3300
Conversation
PR SummaryThis PR refactors the Factory Pattern implementation to use the Factory Enum Pattern. It moves object creation logic into an enum ( Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- a1b64c2: feat: add factory enum
Files Processed (13)
- factory-enum/README.md (1 hunk)
- factory-enum/etc/factory-sequence-diagram.png (0 hunks)
- factory-enum/etc/factory.urm.png (0 hunks)
- factory-enum/etc/factory.urm.puml (1 hunk)
- factory-enum/pom.xml (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/App.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/ExcelProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessorType.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/PDFProcessor.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/AppTest.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/FileProcessorTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
a1b64c2
to
d9d283d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- d9d283d: feat: add factory enum
Files Processed (13)
- factory-enum/README.md (1 hunk)
- factory-enum/etc/factory-sequence-diagram.png (0 hunks)
- factory-enum/etc/factory.urm.png (0 hunks)
- factory-enum/etc/factory.urm.puml (1 hunk)
- factory-enum/pom.xml (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/App.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/ExcelProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessorType.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/PDFProcessor.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/AppTest.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/FileProcessorTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
d9d283d
to
4359e00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 4359e00: feat: add factory enum
Files Processed (13)
- factory-enum/README.md (1 hunk)
- factory-enum/etc/factory-sequence-diagram.png (0 hunks)
- factory-enum/etc/factory.urm.png (0 hunks)
- factory-enum/etc/factory.urm.puml (1 hunk)
- factory-enum/pom.xml (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/App.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/ExcelProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessorType.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/PDFProcessor.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/AppTest.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/FileProcessorTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
4359e00
to
bcabb8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- bcabb8f: feat: add factory enum
Files Processed (13)
- factory-enum/README.md (1 hunk)
- factory-enum/etc/factory-sequence-diagram.png (0 hunks)
- factory-enum/etc/factory.urm.png (0 hunks)
- factory-enum/etc/factory.urm.puml (1 hunk)
- factory-enum/pom.xml (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/App.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/ExcelProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessor.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/FileProcessorType.java (1 hunk)
- factory-enum/src/main/java/com/iluwatar/factory/PDFProcessor.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/AppTest.java (1 hunk)
- factory-enum/src/test/java/com/iluwatar/factory/FileProcessorTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
I think you should create new issue for this one |
Pull Request Template
What does this PR do?
Moves object creation logic into enum (FileProcessorType)
Removes the need for a separate factory class
Why is this change necessary?
Simplifies the codebase by eliminating boilerplate factory classes
Improves readability and maintainability
Leverages type-safe enum-based instantiation
Aligns with modern Java practices (e.g. Enum Singleton)