-
-
Notifications
You must be signed in to change notification settings - Fork 27k
Refactor Task execution to support asynchronous callbacks #3274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HY-love-sleep
wants to merge
5
commits into
iluwatar:master
Choose a base branch
from
HY-love-sleep:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5d157d6
refactor: Refactor Task execution to support asynchronous callbacks
HY-love-sleep b42dc28
fix: CallbackTest
HY-love-sleep 12a7f1d
chore: code style
HY-love-sleep 5f8069b
Merge remote-tracking branch 'upstream/master'
HY-love-sleep a86c211
feat: display synchronous and asynchronous callbacks
HY-love-sleep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,8 @@ | |
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import java.util.concurrent.CountDownLatch; | ||
import java.util.concurrent.TimeUnit; | ||
|
||
/** | ||
* Add a field as a counter. Every time the callback method is called increment this field. Unit | ||
|
@@ -39,19 +41,30 @@ class CallbackTest { | |
private Integer callingCount = 0; | ||
|
||
@Test | ||
void test() { | ||
Callback callback = () -> callingCount++; | ||
void test() throws InterruptedException { | ||
CountDownLatch latch = new CountDownLatch(1); | ||
|
||
var task = new SimpleTask(); | ||
CountDownLatch finalLatch = latch; | ||
Callback callback = () -> { | ||
callingCount++; | ||
finalLatch.countDown(); | ||
}; | ||
|
||
assertEquals(Integer.valueOf(0), callingCount, "Initial calling count of 0"); | ||
var task = new SimpleTask(); | ||
|
||
task.executeWith(callback); | ||
|
||
latch.await(5, TimeUnit.SECONDS); | ||
|
||
assertEquals(Integer.valueOf(1), callingCount, "Callback called once"); | ||
|
||
callingCount = 0; | ||
latch = new CountDownLatch(1); | ||
|
||
task.executeWith(callback); | ||
|
||
assertEquals(Integer.valueOf(2), callingCount, "Callback called twice"); | ||
latch.await(5, TimeUnit.SECONDS); | ||
|
||
assertEquals(Integer.valueOf(1), callingCount, "Callback called once again"); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test uses |
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test uses
await(5, TimeUnit.SECONDS)
which might lead to flaky tests if the task takes longer than 5 seconds to complete. Consider using a more robust mechanism for waiting, such as a timeout with a more appropriate duration or a different synchronization primitive.