Conversation
- Add optional rename=… argument. - Add only sums needed for conversion, not all possible sums. - Adjust logic for dimension renames: - Infer dimensions to rename from var_parts. - Don't mix defaults and explicit/user-supplied values. - Validate resulting arg.
Chain directly to IAMCConversion.{__init__,add_tasks}.
khaeru
added
enh
- Move out of .model.transport to general .report.util. - Rename to store_write_ts(). - Adjust usage.
- Add keys "all::iamc+csv", "all::iamc+xlsx", etc. to defaults.
…invoking get_technology_groups()
- Preserve same units as input quantity. - Drop dimensions if they would be dropped by select(), given the indexers.
- Adjust test expectations.
This ensures "all::iamc" is created, if it does not already exist.
- Replace reporting of GDP to IAMC structure in report/global.yaml. - Add to default .report.Config.callback.
- Replace reporting of prices to IAMC structure in report/global.yaml. - Add to default .report.Config.callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454.
How to review
TBA
PR checklist