Add K-HPMR Thermomechanics Model#831
Conversation
|
ref #830 |
GiudGiud
left a comment
GiudGiud
left a comment
There was a problem hiding this comment.
is the technical report out for this model? I don't see any new reference.
The approach for mechanics seems similar to Kendrick's thesis at MIT, you might want to cite it there
It would be nice to point to mesh convergence studies in that report too.
Have we done homogenized thermo-mechanics at the core scale before @gambka ? Is it an established methodology?
56b0ffd to
bb62443
Compare
7912db0 to
946b94c
Compare
We've used homogenization techniques for thermal solutions for other applications. I'm not aware of full core scale thermo-mechanics applications, but I'd have to read up on the approach used here. There are established homogenization methods. Applications of these techniques have been mostly applied to upscaling of lower-length scale models and their information into engineering scale studies. An example is provided here: 10.1016/j.commatsci.2014.12.039 |
soonklee
left a comment
soonklee
left a comment
There was a problem hiding this comment.
Thanks for the thorough review @GiudGiud. Comments are addressed below.
Changes include:
- Figures resized to <500kb as requested
- Mesh file properly tracked with git lfs, including cleaning the raw binary out of early commit history
- Markdowns revised as requested
- Input files revised as requested, plus a couple of minor clarifying comments added
The model is updated and ready for further review.
Note that this branch was rebased to fix the lfs history.
…el.md Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
…el.md Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
…el.md Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
soonklee
left a comment
soonklee
left a comment
There was a problem hiding this comment.
Minor revisions made to inputs.
|
Needs testing. If you're not adding it I'll do it when I have time |
I haven't written a tests spec before, but I'll get one set up and push it to PR soon. |
|
I added the initial regression test structure following the existing examples. I would appreciate feedback on whether the current test settings are appropriate. |
| executable_pattern = 'dire_wolf*' | ||
| cli_args = "Executioner/richardson_max_its=2 Executioner/richardson_abs_tol=1e-1 Outputs/csv=true " | ||
| "Outputs/file_base=K-HPMR_GRIFFIN_out Outputs/exodus=false MultiApps/bison/cli_args='Outputs/exodus=false'" | ||
| min_parallel = 48 |
There was a problem hiding this comment.
unfortunately too much. create an hpc_tests file and the tests for that model will run there
There was a problem hiding this comment.
I'll revise tests and hpc_tests on mrad correctly.
4 participants
No description provided.