feat: add scale factor to window opened event#3279
Merged
hecrj merged 1 commit intoiced-rs:masterfrom Mar 14, 2026
Merged
Conversation
edwloef
force-pushed
the
window-opened-scale-factor
branch
from
e9805ed to
05d16d9
Compare
Member
|
This is fine but, in my experience, the initial scale factor can be wrong often. In Hyprland at least, the initial scale factor is always 1 and it's only after the opening animation finishes that the proper scale factor event is received. |
Contributor
Author
|
Interesting. I've only tested this on Sway, where it works properly. Does Hyprland fire a |
hecrj
approved these changes
Mar 14, 2026
Member
Yes, but it takes a second; so if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and remove one small helper on
Windowthat wasn't consistently used anyways.This makes it possible to immediately know the system scale factor of a window, in contrast to only after it changes once. With some (only slightly messy) math and only a little bit of flashing on scale factor change, this makes it possible to control the physical size of windows from Iced.