fix: Use adjusted instead of absolute cursor position in TextInput#3221
Open
Koranir wants to merge 3 commits intoiced-rs:masterfrom
Open
fix: Use adjusted instead of absolute cursor position in TextInput#3221Koranir wants to merge 3 commits intoiced-rs:masterfrom
TextInput#3221Koranir wants to merge 3 commits intoiced-rs:masterfrom
Conversation
Makes it so that when the cursor moves off the input, selection will still continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3214
I missed it initially, but
TextInputis using the absolute position of the cursor in the cursor/touch events instead of the adjusted values given by the parent widget.Note: I don't know if it's better to useNeither are proper here.cursor.position_overorcursor.position_inhere, both seemed to work? Additionally, this might break touch, I can't test that.P.S. It might be worth looking into removing the position values from the Cursor/FingerMoved events to avoid this happening in the future.