Fix: sensor should emit on_show every time it pops into view#3220
Open
alex-ds13 wants to merge 1 commit intoiced-rs:masterfrom
Open
Fix: sensor should emit on_show every time it pops into view#3220alex-ds13 wants to merge 1 commit intoiced-rs:masterfrom
on_show every time it pops into view#3220alex-ds13 wants to merge 1 commit intoiced-rs:masterfrom
Conversation
- If no `on_hide` is set, then the sensor was only emitting `on_show` once, the first time it popped into view. After that, if it popped out of view the `has_popped_in` variable wasn't being set to `false` so it thought the sensor was always in view and never emitted the `on_show` again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no
on_hideis set, then the sensor was only emittingon_showonce, the first time it popped into view. After that, if it popped out of view thehas_popped_invariable wasn't being set tofalseso it thought the sensor was always in view and never emitted theon_showagain.If the user wants to have the behavior as it is currently (only emitting once), then it should be on them to implement that logic. The sensor should always emit what it "senses", that is it should always generate messages when it pops in and out of view.