Skip to content

FEAT: HiRAG Hierarchical RAG Re-ranking Implementation #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iberi22 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FEAT: HiRAG Hierarchical RAG Re-ranking Implementation #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/synapse-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ lazy_static = "1.5.0"

[dev-dependencies]
tokio = { workspace = true }
synapse-infra = { path = "../synapse-infra" }
synapse-infra = { path = "../synapse-infra", default-features = false }
Copy link

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved maintainability, it would be beneficial to add a comment explaining why default-features is disabled for this dev-dependency. This context is valuable for future developers who might not be aware of the circular dependency and the potential build issues it prevents.

Suggested change
synapse-infra = { path = "../synapse-infra", default-features = false }
# Disable default features to break the circular dev-dependency on `synapse-infra`
# and prevent pulling in heavy optional features (e.g., 'vision') during tests.
synapse-infra = { path = "../synapse-infra", default-features = false }

Loading