Changed IModelReadRpcInterface.getAllCodeSpecs to use ECSqlReader
#8179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiutaurasSk
requested review from
a team,
aruniverse,
bbastings,
ben-polinsky,
paulius-valiunas and
wgoehrig
as code owners
|
|
GytisCepk
reviewed
Jun 5, 2025
LiutaurasSk
changed the title
IModelReadRpcInterface.getAllCodeSpecs to use queryRowsIModelReadRpcInterface.getAllCodeSpecs to use ECSqlReader
LiutaurasSk
force-pushed
the
liutauras/change-getallcodespecs
branch
from
9d7d875 to
2cfd5e7
Compare
Added back getAllCodeSpecs Changed _loadCodeSpec to work with new runQuery implementation Changed forming of query's where clause Removed unrelated change Changed query forming Moved query constant inside the function Changed if condition Added tests for CodeSpecs._isCodeSpecProperties() Cleaned up tests Reversed whitespace change Update identified type Changed type
LiutaurasSk
force-pushed
the
liutauras/change-getallcodespecs
branch
from
2cfd5e7 to
44e8b13
Compare
GytisCepk
reviewed
Jun 11, 2025
.../@itwin/rpcinterface-full-stack-tests/liutauras-change-getallcodespecs_2025-06-06-06-34.json
Outdated
Show resolved
Hide resolved
full-stack-tests/core/src/frontend/standalone/CodeSpecs.test.ts
Outdated
Show resolved
Hide resolved
full-stack-tests/core/src/frontend/standalone/CodeSpecs.test.ts
Outdated
Show resolved
Hide resolved
full-stack-tests/core/src/frontend/standalone/CodeSpecs.test.ts
Outdated
Show resolved
Hide resolved
…ved unnecessary assertions.
GytisCepk
approved these changes
Jun 11, 2025
…/iTwin/itwinjs-core into liutauras/change-getallcodespecs
Contributor
Author
|
Could @iTwin/itwinjs-core-admins and @iTwin/itwinjs-core-display please review this PR? |
aruniverse
reviewed
Jun 20, 2025
Member
aruniverse
left a comment
aruniverse
left a comment
There was a problem hiding this comment.
great work @LiutaurasSk!
1 minor comment, on optimizing query (if possible)
aruniverse
approved these changes
Jun 20, 2025
markschlosseratbentley
approved these changes
Jun 26, 2025
paulius-valiunas
approved these changes
Jun 30, 2025
khanaffan
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IModelReadRpcInterface.getAllCodeSpecsto useECSqlReader