Skip to content

Editor: ES Modules #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Editor: ES Modules #7897

wants to merge 6 commits into from

Conversation

pankhur94
Copy link
Contributor

@pankhur94 pankhur94 commented Mar 27, 2025 •
edited
Loading

  • Full ESM support

@pankhur94 pankhur94 marked this pull request as ready for review March 27, 2025 21:59
@pankhur94 pankhur94 requested review from a team, bbastings and pmconne as code owners March 27, 2025 21:59
@pankhur94 pankhur94 requested a review from grigasp March 27, 2025 21:59
grigasp
grigasp approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@grigasp grigasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only comment I have is regarding PR description:

Run unit tests on ESM

Doesn't look like these packages have any tests.

@pankhur94 pankhur94 changed the title Editor: ESM Modules Editor: ES Modules Mar 28, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 2, 2025

This pull request is now in conflicts. Could you fix it @pankhur94? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@aruniverse aruniverse marked this pull request as draft May 30, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmconne pmconne pmconne approved these changes

@grigasp grigasp grigasp approved these changes

@bbastings bbastings bbastings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pankhur94 @pmconne @grigasp @bbastings