fix(mcp): CORS middleware, renaming, error handling #9423
+330
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithBasePath is deprecated
…on; fix error handling
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
matthewmcneely
commented
May 22, 2025
| @@ -102,22 +102,22 @@ func NewMCPServer(connectionString string, readOnly bool) (*server.MCPServer, er | |||
| s.AddTool(alterSchemaTool, func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) { | |||
| schema, ok := request.GetArguments()["schema"].(string) | |||
| if !ok { | |||
| return nil, fmt.Errorf("schema must be present") | |||
| return mcp.NewToolResultError("Schema must be present"), nil | |||
There was a problem hiding this comment.
Handling errors via mcp.NewToolResultError is the correct mode. If we return an err, the SSE server internals will return a 500 server error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Note, there's a MCP demo client here that you can spin up to test the SSE implementation.
Checklist