Skip to content

Feature/atl 6719 implementation #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 40 commits into from
Closed

Feature/atl 6719 implementation #157

wants to merge 40 commits into from

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented May 3, 2024

Description:

Adding Ed25519 derivation and conversion to X25519, to be able to create masterKeys in the SDKs.

  • Added git submodule for Ed25519 derivation, and wired into build.
  • Created EdHDKey classes in all targets, to utilise submodule.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

elribonazo and others added 14 commits April 10, 2024 12:55
@elribonazo
fix: Adding the uniffy defrinition file and change the folder paths f…
a9675b1 
…or the correct ones
@elribonazo
fix: EdHDKey build for kmm
4eb0600 
Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
@curtis-h
js EdHDKey + external
de2a13b
@elribonazo
fix: import the bip32 package from js
fe6e2a9
@curtis-h
including rust-ed25519-bip32 submodule
21fb5a5
@curtis-h
split build.gradle
9980325
@elribonazo
fix: improve build gradle.
ee64f52
@hamada147
fix: Handle some compilation issues
ede1d3c 
- Fixed a couple of linked issues
- Fixed missing def file
- Fixed depends on issue that happened from creating a new source set while using DefaultHierarchyTemplate
- Fixed not having Android Src folder
- Fixed missing header file on copying files
- Fixed missing CInterop method

Signed-off-by: Ahmed Moussa <[email protected]>
@curtis-h
update wasm copy dir and add basic test
ff54776
@hamada147
fix: updating namespace in UDL to correctly map to generated binaries
ce6d28f 
Signed-off-by: Ahmed Moussa <[email protected]>
@curtis-h
fix: forcing ed25519 wasm into test folder
7ef2af0
@curtis-h
lint
1f3ec54
@elribonazo
fix: add convert function for KMMEdPrivate key conversion to x25519Pr…
c7aac59 
…ivate keySigned-off-by: Francisco Javier Ribó Labrador <[email protected]>
@curtis-h
fix: JS wrap EdHdKey.initFromSeed in companion to make static
e17fb3c 
Signed-off-by: Curtis Harding <[email protected]>
curtis-h
curtis-h commented May 3, 2024
View reviewed changes
@curtis-h curtis-h force-pushed the feature/ATL-6719-implementation branch 5 times, most recently from f633ac5 to 6f1e8cf Compare May 3, 2024 11:48
@curtis-h curtis-h force-pushed the feature/ATL-6719-implementation branch from 9c6c0fa to ff41e2e Compare May 3, 2024 12:21
hamada147 and others added 8 commits May 6, 2024 17:27
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-6719-implementation branch from b89d8fd to 3ca4e01 Compare May 8, 2024 10:47
curtis-h added 4 commits May 8, 2024 15:35
@curtis-h
rust-ed25519-bip32 submodule update
7d0ea3d 
Signed-off-by: Curtis Harding <[email protected]>
@curtis-h
rust-ed25519-bip32 submodule pivot to functions
50cd101 
Signed-off-by: Curtis Harding <[email protected]>
@curtis-h
lint
484dbcd 
Signed-off-by: Curtis Harding <[email protected]>
@curtis-h
jsTest fix attempt
5d30c5d 
Signed-off-by: Curtis Harding <[email protected]>
@atala-dev
Copy link
Contributor

atala-dev commented May 13, 2024 •
edited
Loading

Code Coverage

File Coverage [61.79%] ❌
apollo/src/androidMain/kotlin/io/iohk/atala/prism/apollo/derivation/EdHDKey.kt 63.04% ❌
apollo/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
apollo/src/appleMain/kotlin/io/iohk/atala/prism/apollo/derivation/EdHDKey.kt 63.04% ❌
apollo/src/appleMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
apollo/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/EdHDKey.kt 63.04% ❌
apollo/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/ConvertEd25519.kt 0.00% ❌
apollo/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
apollo/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
apollo/src/jsMain/kotlin/io/iohk/atala/prism/apollo/derivation/EdHDKey.kt 63.04% ❌
apollo/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
apollo/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/derivation/EdHDKey.kt 63.04% ❌
apollo/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 54.55% ❌
Total Project Coverage 89.22% ❌

hamada147
hamada147 suggested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@hamada147 hamada147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small changes, but awesome work mate 👌

@curtis-h
Copy link
Contributor Author

merged in #161

@curtis-h curtis-h closed this May 22, 2024
@hamada147 hamada147 deleted the feature/ATL-6719-implementation branch May 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo elribonazo is a code owner

@yshyn-iohk yshyn-iohk Awaiting requested review from yshyn-iohk yshyn-iohk is a code owner

@cristianIOHK cristianIOHK Awaiting requested review from cristianIOHK

@amagyar-iohk amagyar-iohk Awaiting requested review from amagyar-iohk amagyar-iohk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curtis-h @atala-dev @hamada147 @goncalo-frade-iohk @elribonazo