Skip to content

feat(Slider): Add slider thumb positioning prop #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpenilla
Copy link
Contributor

@jpenilla jpenilla commented May 20, 2025

Looking for feedback before I add docs - not sure if this property should be moved to the thumbs themselves somehow

Motivation:
image
With an equal padding around the slider, the containment makes alignment look 'off'.

Copy link
Contributor

github-actions bot commented May 20, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview b2e7ef0

@jpenilla jpenilla changed the title Allow disabling slider thumb padding feat(Slider): Add slider thumb positioning prop May 20, 2025
@huntabyte
Copy link
Owner

I like this idea!

Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: b2e7ef0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jpenilla jpenilla marked this pull request as ready for review May 23, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants